Skip to content

Conversation

@coltenkrauter
Copy link
Contributor

@coltenkrauter coltenkrauter commented Apr 16, 2025

Description

#32
#27

Type of Change

  • New feature
  • Bug fix
  • Chore
  • Configuration
  • Documentation
  • Refactoring
  • Hotfix
  • Security
  • GitFlow

Testing

  • Executed locally
  • Unit tests
  • Integration tests
  • Load tests
  • PR Status checks
  • Workflow execution (against non-default branch)
  • Other (explain)
  • Not worth it (explain)
  • Not applicable

Checklist

[Not required to be completed, just check off what you've done.]

  • Commits are reasonably sized and the commit message describes the changes well.
  • I have made corresponding changes to the documentation.
  • I have added unit tests for changes to business logic.
  • I have emitted metrics so our team can monitor the health of this system related to these changes.
  • I have added logs to ensure debugging is straight-forward when issues arise.
  • I have considered failure modes (e.g. major dependency becomes unavailable, bad data passed in).
  • I have added a comment to this PR to discuss any concerns/risks of these changes. This might include effects on performance, new dependencies, changes in behavior, or difficult things to test.
  • I have considered whether some of these changes should go into a shared package to increase code reusability.

@coltenkrauter coltenkrauter self-assigned this Apr 16, 2025
@coltenkrauter coltenkrauter merged commit 62e3406 into main Apr 16, 2025
4 checks passed
@coltenkrauter coltenkrauter deleted the feature/coltenkrauter/2025-04-15/1 branch April 16, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants